Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Aug 25, 2025

Hi all,

This pull request contains a backport of commit 4abb5e4a from the openjdk/jdk repository.

The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8157758 needs maintainer approval

Issue

  • JDK-8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/682/head:pull/682
$ git checkout pull/682

Update a local copy of the PR:
$ git checkout pull/682
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 682

View PR using the GUI difftool:
$ git pr show -t 682

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/682.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4abb5e4aafe05871a07d510f002a38298fe4dbb2 8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 25, 2025
@mrserb mrserb marked this pull request as ready for review September 4, 2025 17:38
@openjdk
Copy link

openjdk bot commented Sep 4, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 4, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant